Hi,
I installed the SI5351 library which goes with the Adafruit module (https://www.adafruit.com/product/2045).
Following your example (lines 16-22), I used the piece of code which tests the I²C connection through wire.begin () included in the library's CPP.
I noticed that from the moment the module is not plugged in, no error was found. However in your example, we are seen to see appear "Ooops, no Si5351 detected ... Check your wiring or I2C ADDR!" ; instead the code continues its path to loop ().
So I went into the bookstore to see what was going on. There is the presence of an "errors.h" file which contains a list of errors which must be reported.
Unfortunately, in your Adafruit_SI5351.cpp code, no error is encoded. The "errors.h" file is useless.
Would it be possible for you to correct the library to take care of the errors?
Thank you in advance for your help on this subject.
Regards,
Alex
SI5351 library: The errors are not correctly handled.
Moderators: adafruit_support_bill, adafruit
Please be positive and constructive with your questions and comments.
- Almisuifre
- Posts: 4
- Joined: Sun Apr 25, 2021 3:33 pm
- adafruit_support_carter
- Posts: 29209
- Joined: Tue Nov 29, 2016 2:45 pm
Re: SI5351 library: The errors are not correctly handled.
Sounds like you are wanting this to be implemented?
https://github.com/adafruit/Adafruit_Si ... 51.cpp#L92
https://github.com/adafruit/Adafruit_Si ... 51.cpp#L92
- Almisuifre
- Posts: 4
- Joined: Sun Apr 25, 2021 3:33 pm
Re: SI5351 library: The errors are not correctly handled.
hi,
Thanks for your feedback.
Indeed I need to know if there are any errors, for example when the connection is faulty. I would be happy if the code was in place.
Thank you
Thanks for your feedback.
Indeed I need to know if there are any errors, for example when the connection is faulty. I would be happy if the code was in place.
Thank you
- adafruit_support_carter
- Posts: 29209
- Joined: Tue Nov 29, 2016 2:45 pm
Re: SI5351 library: The errors are not correctly handled.
The ASSERT_STATUS macro should be doing that.
To be clear - the issue is the behavior when a Si5351 is not connected at all?
To be clear - the issue is the behavior when a Si5351 is not connected at all?
- Almisuifre
- Posts: 4
- Joined: Sun Apr 25, 2021 3:33 pm
Re: SI5351 library: The errors are not correctly handled.
That's exactly it, ASSERT_STATUS should work. But I don't know why it is not running.
- adafruit_support_carter
- Posts: 29209
- Joined: Tue Nov 29, 2016 2:45 pm
Re: SI5351 library: The errors are not correctly handled.
Would you mind opening a new issue for this in the library repo:
https://github.com/adafruit/Adafruit_Si5351_Library/
If you don't have a Github account I can just make one for you.
https://github.com/adafruit/Adafruit_Si5351_Library/
If you don't have a Github account I can just make one for you.
- Almisuifre
- Posts: 4
- Joined: Sun Apr 25, 2021 3:33 pm
Re: SI5351 library: The errors are not correctly handled.
Hi
These days, I did not have time to make the statement on the github.
Today, I'm going to open a ticket to relay our conversation on the github.
Thank you, however, for all your help.
These days, I did not have time to make the statement on the github.
Today, I'm going to open a ticket to relay our conversation on the github.
Thank you, however, for all your help.
Please be positive and constructive with your questions and comments.